-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle lief 0.15 renaming of LOAD_COMMAND_TYPES and ELF_CLASS #5595
base: 25.1.x
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #5595 will not alter performanceComparing Summary
|
Thanks a lot for the PR! Given that this still breaks with 0.15 (and thus the version that conda-build 25.1 claimed compatibility to), I think it would be a good idea to backport this patch. |
I see you've got 25.1.x and 24.11.x branches here, but I don't think #5565 was included in 24.11.x. would you like me to open a separate PR, or change the target branch, or will you handle the cherry-picking? |
No need for action right now. First off, a backport is not my decision, and secondly, I think it needs to land on main first anyway |
I think we can tsrhet 25.1.x. That branch will be synced with main later. |
Could you retarget the branch then? Contributors can't do it, it needs maintainer rights Edit: apparently, I was wrong. 🤷 🙃 |
I tried that out but it looked a little messy adding in 4 unrelated commits that exist on main but not the 25.1.x branch |
Obviously you'd have to rebase out those commits. |
f96a7ee
to
642f9bc
Compare
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Description
fix #5594 - missed osx parts that should have included in #5565
handle lief 0.15 renaming of
LOAD_COMMAND_TYPES
https://lief.re/doc/stable/changelog.html#july-21th-2024
Checklist - did you ...
news
directory (using the template) for the next release's release notes?